GLASGOW | MAY_2025 | MOHAMMED HUSSEIN | FORM CONTROL #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
reviewed
Jun 2, 2025
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="name">Name</label> | ||
| <input type="text" name="name" id="name" minlength="2" required /> |
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
Form-Controls/index.html
Outdated
Comment on lines
59
to
60
| <legend>Size</legend> | ||
| <br /> |
There was a problem hiding this comment.
The spacing after the <legend> tags in the two
Form-Controls/index.html
Outdated
Comment on lines
62
to
70
| <label for="XS">XS</label> | ||
| <input type="radio" name="Size" id="XS" value="XS" required /> | ||
| </div> | ||
| <br /> | ||
| <div> | ||
| <label for="S">S</label> | ||
| <input type="radio" name="Size" id="S" value="S" required /> | ||
| </div> | ||
| <br /> |
There was a problem hiding this comment.
Can you find out from ChatGPT, "when to use radio buttons and when to use a dropdown list?" You don't have to change your implementation in this exercise.
cjyuan
added
Reviewed
…tween the size section and the submit button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.